Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing fails on some unquoted url()s #20

Open
data-enabler opened this issue Mar 2, 2018 · 1 comment
Open

Parsing fails on some unquoted url()s #20

data-enabler opened this issue Mar 2, 2018 · 1 comment

Comments

@data-enabler
Copy link

Thanks for all the work so far; looks like there are some issues with the handling of unquoted url values.

Input:

.x {background: url(http://mysite.example.com/mycursor.png);}

Error:

Error: Expecting punctuation: ")" (1:61)
    at InputStream.err (scss-parser/dist/input-stream.js:122:13)
    at Object.err (scss-parser/dist/input-stream.js:161:20)
    at TokenStream.err (scss-parser/dist/token-stream.js:297:40)
    at Object.err (scss-parser/dist/token-stream.js:634:20)
    at Parser.skip_type (scss-parser/dist/parse.js:199:21)
    at Parser.skip_punctuation (scss-parser/dist/parse.js:214:29)
    at Parser.parse_arguments (scss-parser/dist/parse.js:592:37)
    at Parser.parse_function (scss-parser/dist/parse.js:624:23)
    at Parser.maybe_function (scss-parser/dist/parse.js:611:78)
    at Parser.parse_atom (scss-parser/dist/parse.js:420:19)

Input:

.x {background: url(../valid/path.png);}

Error:

Error: Selector ("class") expected "identifier" or "interpolation" (1:23)
    at InputStream.err (scss-parser/dist/input-stream.js:122:13)
    at Object.err (scss-parser/dist/input-stream.js:161:20)
    at TokenStream.err (scss-parser/dist/token-stream.js:297:40)
    at Object.err (scss-parser/dist/token-stream.js:634:20)
    at Parser.parse_selector (scss-parser/dist/parse.js:728:21)
    at /usr/local/lib/node_modules/migrate-font-sizes/node_modules/scss-parser/dist/parse.js:435:25
    at Parser.maybe_function (scss-parser/dist/parse.js:609:14)
    at Parser.parse_atom (scss-parser/dist/parse.js:420:19)
    at Parser.parse_expression (scss-parser/dist/parse.js:394:25)
    at Parser.parse_arguments (scss-parser/dist/parse.js:581:37)
@LeanKhan
Copy link

Any updates on this, did you have to quote the URL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants