New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer - bypass needing to click the placeholder image #244

Open

joseph-bayer opened this issue Jan 29, 2025 · 1 comment

joseph-bayer commented Jan 29, 2025

Is there a setting to disable the placeholder image in the Viewer component?

If not, I could contribute if somebody could give me some direction!

Member

mathewjordan commented Jan 30, 2025

@joseph-bayer The bypass would be not having a placeholderCanvas property like this method https://iiif.io/api/cookbook/recipe/0013-placeholderCanvas/. Clover want to respect that if it exists. I suppose, we could add some override for implementers of Clover to ignore this property.

The config options would need to negate the existence of the placeholderCanvas here:

clover-iiif/src/components/Viewer/Painting/Painting.tsx

Lines 44 to 47 in b33af20

    
           const placeholderCanvas = normalizedCanvas?.placeholderCanvas?.id; 
        
           const hasPlaceholder = Boolean(placeholderCanvas); 
        
           const hasChoice = Boolean(painting?.length > 1); 
        
           const showPlaceholder = placeholderCanvas && !isInteractive && !isMedia;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment