Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking: Change the logic that auto-selects a fip network for new projects #969

Open
edda opened this issue Oct 20, 2021 · 0 comments
Open
Assignees
Labels
neverstale will be ignored by close-stale-issues workflow

Comments

@edda
Copy link
Collaborator

edda commented Oct 20, 2021

Currently the way this is implemented is that we essentially have a hard-coded list of network name candidates that we try to fetch one after the other until we get a network that matches the name. We try this in a specific order (highest number first, because that is the newest network with the most available fips). However it requires us to add a new highest number whenever a new network is added.

Proposal to fix this:
Fetch all networks (maybe it's even possible nowadays to fetch with wildcard), then filter them with a regex (for the name match) and pick the one with the highest number at the end.

The current implementation can be found here: https://github.com/sapcc/elektra/blob/master/plugins/networking/app/services/service_layer/networking_services/network.rb#L71-L89

@github-actions github-actions bot added the Stale label Sep 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
@edda edda reopened this Sep 12, 2024
@edda edda added neverstale will be ignored by close-stale-issues workflow and removed Stale labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neverstale will be ignored by close-stale-issues workflow
Projects
None yet
Development

No branches or pull requests

2 participants