-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Effects not showing on physicsless parts #25
Comments
Just looked in the SmokeScreen code, it seems it prevents particles when there is no rigidbody, which explains the problem. In these cases, would it be possible to use the parent parts' rigidbody instead? |
I am not seeing it after a quick scan of the code. Can you point me to that rigibody test and I ll see how many change it require. |
I've just done some testing with the modifications above, and the numbers returned in a simple test were identical to the numbers produced with the current method. Not saying that this is the solution, as there are likely issues somewhere, but plumes now show on physicsless parts |
physicsless parts should not be used at all except for some really specific cases. I am not adding a change that promote miss use of the part config. Edit : and a physic less engine is wrong on so many point... |
Okay then, I'll see about resolving this on RealPlumes end then, by removing the PhysicsSignificance line. Thanks anyway! |
After trying to make RealPlume configs for certain engines, I noticed some parts won't show effects applied with SmokeScreen. After a few experiments, I found that parts with PhysicsSignificance = 1 in there configs will not show effects at all.
The text was updated successfully, but these errors were encountered: