Apply suggestions from code review

Co-authored-by: Mickael Bourgois <35171168+BourgoisMickael@users.noreply.github.com>

Author: tcarmet

.github/workflows/release.yaml

@@ -31,7 +31,7 @@ jobs:
           echo PKG_BASENAME="$(basename $(jq -r .name < package.json))" >> $GITHUB_ENV
       - name: Ensure the branch is protected
         run: |
-          if [[ "${{ github.ref_protected }}" == "false" ]]; then
+          if [[ "${{ github.ref_protected }}" = "false" ]]; then
             echo "::error::The branch ${{ github.ref }} is not protected"
             exit 1
           fi
@@ -54,7 +54,8 @@ jobs:
           cache: yarn
           node-version: '16'
           registry-url: https://npm.pkg.github.com
-      - run: yarn install --frozen-lockfile
+      - name: install dependencies
+        run: yarn install --frozen-lockfile
       - name: Publish to GitHub Packages
         run: npm publish --provenance
         env:

.github/workflows/tests.yaml

@@ -29,7 +29,7 @@ jobs:
       run: yarn lint
     - name: Set common env vars for npm publish
       run: |
-        echo "SHORTSHA=$(echo $GITHUB_SHA | cut -c1-7)" >> $GITHUB_ENV
+        echo "SHORTSHA=$(git rev-parse --short $GITHUB_SHA)" >> $GITHUB_ENV
         echo "PKG_VERSION=$(jq -r .version < package.json)" >> $GITHUB_ENV
     - name: Set version for work in progress
       run: yarn version --no-git-tag-version --new-version "0.0.0-sha.${SHORTSHA}"