Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Key Vault use RBAC instead of Access Policies #25

Open
o-l-a-v opened this issue Jun 17, 2024 · 1 comment
Open

Feature request - Key Vault use RBAC instead of Access Policies #25

o-l-a-v opened this issue Jun 17, 2024 · 1 comment

Comments

@o-l-a-v
Copy link

o-l-a-v commented Jun 17, 2024

Using access policies with Key Vault is a) legacy vs. RBAC, and b) problematic with IaC.

The problem with IaC is that having accessPolicies inside the Key Vault resource in ARM or Bicep makes access policies indempotent: All other access policies are wiped. That could be worked around by creating a child resource vaults/accessPolicies after the Key Vault:

BUT, one can't create a Key Vault with access policies without specifying accessPolicies:

I can't get Bicep what-if to show changes for accessPolicies either, so we're blind on changes before pushing the big deploy button.

The only logical conclusion here would be to change Key Vault to using RBAC, as far as I can see.

@bb-froggy
Copy link
Member

Yes, agreed, we'll switch to RBAC.

I initially thought that it would be a good thing that with Access Policies, you would have that very short list of identities that can access the private key (i.e., only SCEPman), and not have many identities that inherit permissions, e.g. from the subscription or resource group. It turns out that even Owner permissions do not allow access to the actual secrets or private keys, so the inheritance is not actually a problem -- it is still only SCEPman who can access the private key, as long as nobody has specific Key Vault permissions on a superordinate organizational structure like the resource group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants