From 1d56277231a77383cb4e524dc75597fd23e201ad Mon Sep 17 00:00:00 2001 From: Samuel Veiga Rangel <82840278+samuelveigarangel@users.noreply.github.com> Date: Mon, 16 Dec 2024 14:56:05 -0300 Subject: [PATCH] Corrige contrib_name (#775) * fix Contrib.contrib_name * Fix ArticleContribTest.test_data --- packtools/sps/models/article_contribs.py | 2 +- tests/sps/models/test_article_contribs.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packtools/sps/models/article_contribs.py b/packtools/sps/models/article_contribs.py index 0fcfbeb2b..896038fa2 100644 --- a/packtools/sps/models/article_contribs.py +++ b/packtools/sps/models/article_contribs.py @@ -40,7 +40,7 @@ def contrib_ids(self): def contrib_name(self): name = self.node.find("name") if name is not None: - return {item.tag: item.text for item in name} + return {item.tag: item.text for item in name if item.text} @property def contrib_full_name(self): diff --git a/tests/sps/models/test_article_contribs.py b/tests/sps/models/test_article_contribs.py index 680af901d..62d6b3a36 100644 --- a/tests/sps/models/test_article_contribs.py +++ b/tests/sps/models/test_article_contribs.py @@ -754,6 +754,7 @@ def test_data(self): { 'city': None, 'country_name': None, + 'country_code': None, 'email': None, 'id': 'aff4', 'label': 'a', @@ -769,7 +770,6 @@ def test_data(self): } ] } - ] for i, item in enumerate(expected):