From b4444097944e58a2abbf6a34d79972c911504a09 Mon Sep 17 00:00:00 2001 From: archmoj Date: Sat, 7 Aug 2021 12:48:49 -0400 Subject: [PATCH 1/3] ignore lock file --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 0d1b0b0..6342e05 100644 --- a/.gitignore +++ b/.gitignore @@ -12,4 +12,5 @@ logs results npm-debug.log +package-lock.json node_modules/* \ No newline at end of file From 1dc26e0ed4a22e7c83910cba09b90525ef5695dc Mon Sep 17 00:00:00 2001 From: archmoj Date: Sat, 7 Aug 2021 13:39:19 -0400 Subject: [PATCH 2/3] avoid function constructor --- ndarray-ops.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/ndarray-ops.js b/ndarray-ops.js index 2147241..d748923 100644 --- a/ndarray-ops.js +++ b/ndarray-ops.js @@ -40,14 +40,14 @@ function pcompile(user_args) { }) } -function makeOp(user_args) { - var args = [] - for(var i=0; i Date: Mon, 9 Aug 2021 20:41:54 -0400 Subject: [PATCH 3/3] it appears there is no need for the wrapper --- ndarray-ops.js | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/ndarray-ops.js b/ndarray-ops.js index d748923..20179b0 100644 --- a/ndarray-ops.js +++ b/ndarray-ops.js @@ -40,15 +40,8 @@ function pcompile(user_args) { }) } -function wrapper(P) { - return function() { - P.apply(this, arguments) - return arguments[0] - } -} - function makeOp(user_args) { - return wrapper(pcompile(user_args)) + return pcompile(user_args) } var assign_ops = {