Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern CMake for scitokens-cpp #146

Open
bbockelm opened this issue Mar 17, 2025 · 1 comment
Open

Modern CMake for scitokens-cpp #146

bbockelm opened this issue Mar 17, 2025 · 1 comment

Comments

@bbockelm
Copy link
Contributor

As suggested by @amadio in a discussion on the xrootd GitHub tracker (see xrootd/xrootd#2453), it'd be useful to modernize the CMake setup for scitokens-cpp. Items that come to mind:

  • Installing CMake definitions from scitokens-cpp as part of the RPM install.
  • Exporting build targets to make building and linking against scitokens-cpp easier.
  • Exporting a version number for CMake.

@amadio, I roughly know how to do the first two items. Any suggestion on the best way to accomplish the third? When I've done things like that in the past, they've ended up poorly as we always seem to forget to update the code before tagging (it relied on humans to get the versioning correct and humans are poor at process).

@amadio
Copy link

amadio commented Mar 17, 2025

In XRootD I did it in such a way as to automatically convert the tag into a version, see https://github.com/xrootd/xrootd/blob/master/cmake/XRootDVersion.cmake. You can use that pretty much verbatim, just changing the name of the project, then generate a version header like we do in XRootD at config time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants