Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc-8 as pre-commit check #126

Closed
giovp opened this issue Dec 8, 2022 · 2 comments
Closed

add doc-8 as pre-commit check #126

giovp opened this issue Dec 8, 2022 · 2 comments

Comments

@giovp
Copy link
Member

giovp commented Dec 8, 2022

anybody against ?

link: https://github.com/PyCQA/doc8/blob/main/.pre-commit-config.yaml

@grst
Copy link
Collaborator

grst commented Dec 8, 2022

I'm not convinced to add more checks that are not autofixes

@grst
Copy link
Collaborator

grst commented Apr 27, 2023

We defined criteria for new checks in #149 and #142 (comment). doc8 doesn't qualify and shouldn't be added as default check.

@grst grst closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants