Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to AVA v6 #50

Closed
wants to merge 1 commit into from
Closed

Update to AVA v6 #50

wants to merge 1 commit into from

Conversation

razor-x
Copy link
Member

@razor-x razor-x commented Mar 21, 2024

Based on #50

I cannot figure out what is the issue with the test failure. However I have seen this before trying to update this to AVA v6 (still stuck on v5): https://github.com/seamapi/javascript-http

@seambot
Copy link
Contributor

seambot commented Mar 21, 2024

Bundle dist size: 6.9M

@razor-x
Copy link
Member Author

razor-x commented Mar 21, 2024

@codetheweb Just want to see if you have any ideas here given how much you have worked with AVA. This is the first time I've reproduced the same error in two repos, so maybe we can learn something new: seamapi/javascript-http#65

@codetheweb
Copy link
Contributor

Does seamapi/javascript-http use shared workers? I remember seeing this error before in edgespec, but I thought it was my fault at the time.

@razor-x
Copy link
Member Author

razor-x commented Mar 22, 2024

@codetheweb It starts and uses the fake, but I'm not sure if that means it uses shared workers or not.

@codetheweb
Copy link
Contributor

I think it's an internal AVA bug with t.throwsAsync()? I think? Pretty sure it's a result of the Axios error not serializing properly.

e.g. when run outside t.throwsAsync() it works fine, and if you try/catch t.throwsAsync() you can see the internal AVA error

Screenshot 2024-03-21 at 17 11 49

Screenshot 2024-03-21 at 17 12 34

Copy link

stale bot commented Mar 26, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Mar 26, 2024
@stale stale bot closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants