From bd25b9dc09f08fe44042e4e0dcf08c09351d691d Mon Sep 17 00:00:00 2001 From: sect Date: Sun, 16 Jun 2024 00:37:15 +0900 Subject: [PATCH 1/2] refactor: code refactor --- includes/save.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/includes/save.php b/includes/save.php index fec6d03..2fce460 100644 --- a/includes/save.php +++ b/includes/save.php @@ -176,9 +176,10 @@ function save_spreadsheet(): array { ); } -$return = save_spreadsheet(); -$rus = apply_filters( 'google_ss2db_after_save', $return ); -$bool = ( $return['result'] ) ? true : false; +$data = save_spreadsheet(); +apply_filters( 'google_ss2db_after_save', $data ); + +$bool = (bool) $data['result']; $referer = wp_unslash( $_POST['_wp_http_referer'] ); $referer = str_replace( '&settings-updated=true', '', $referer ); $referer = $referer . '&ss2dbupdated=' . $bool; From 3c7f26d3497fcc43d95abff3283d6560cd5dfac4 Mon Sep 17 00:00:00 2001 From: sect Date: Sun, 16 Jun 2024 00:38:36 +0900 Subject: [PATCH 2/2] docs: fix wrong usage example on README --- README.md | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/README.md b/README.md index e67ad98..01e89ba 100644 --- a/README.md +++ b/README.md @@ -95,25 +95,21 @@ add_filter( 'google_ss2db_before_save', function ( $row, $worksheetid, $workshee And also use `add_filter('google_ss2db_after_save', $return_array )` to perform any processing with the return value. ```php -add_filter( 'google_ss2db_after_save', function ( $array ) { - if ( 'My Spreadsheet' === $worksheetname ) { - // $id = $array['id']; - // $date = $array['date']; - // $title = $array['title']; - // $value = $array['value']; - // $work_sheet_id = $array['worksheet_id']; - // $work_sheet_name = $array['worksheet_name']; - // $sheet_name = $array['sheet_name']; - // $result = $array['result']; - - // Do something... - $return = $something; - } else { - $return = $array; +add_filter( 'google_ss2db_after_save', function ( $data ) { + if ( 'My Spreadsheet' === $data['worksheet_name'] ) { + // $id = $data['id']; + // $date = $data['date']; + // $title = $data['title']; + // $value = $data['value']; + // $work_sheet_id = $data['worksheet_id']; + // $work_sheet_name = $data['worksheet_name']; + // $sheet_name = $data['sheet_name']; + // $result = $data['result']; + + // Example + my_callback( $data ); } - - return $return; -} ); +}); ``` ## APIs