Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 🎨 improve team members page styling and add Marton #246

Merged
merged 2 commits into from
May 31, 2024

Conversation

martonvago
Copy link
Contributor

@martonvago martonvago commented May 30, 2024

Description

This PR improves the styling of the team members page and adds Marton.

Desktop:

Smaller screens:
Uploading team-small.png…

Closes #243

Testing

  • Yes
  • No, not needed (give a reason below)
  • No, I need help writing them

Tested in the browser.

Reviewer Focus

This PR only needs a quick review.

Checklist

  • Tests accompany or reflect changes to the code
  • Tests ran and passed locally
  • Ran the linter and formatter
  • Build has passed locally
  • Relevant documentation has been updated

@martonvago martonvago self-assigned this May 30, 2024
#team-members {
display: flex;
justify-content: center;
padding-top: 14px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen some other examples of stuff set to straight pixels, but let me know if there's another preferred way!

@martonvago
Copy link
Contributor Author

martonvago commented May 30, 2024

Here are the screenshots, I can't delete the broken ones from above 🤔

Desktop:
team

Smaller screens:
team-small

about/team/styles.css Outdated Show resolved Hide resolved
@martonvago martonvago marked this pull request as ready for review May 30, 2024 12:45
@martonvago martonvago requested a review from a team as a code owner May 30, 2024 12:45
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!

@lwjohnst86 lwjohnst86 merged commit be33029 into main May 31, 2024
@lwjohnst86 lwjohnst86 deleted the style/update-team-members branch May 31, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Team members page needs to be updated, it is weird
3 participants