Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Clarification on scss_import_paths #33

Open
LucyI opened this issue May 5, 2022 · 9 comments
Open

Need Clarification on scss_import_paths #33

LucyI opened this issue May 5, 2022 · 9 comments

Comments

@LucyI
Copy link

LucyI commented May 5, 2022

Have installed on a new MODX Cloud instance, 2.8.4.pl, with no other extras installed other than CssSweet.

Can't get imports to work in the chunk. The chunk that is created on installation has a commented import:
/* @import 'test.scss'; */

The test.scss file that was created on installation is located in assets/components/csssweet/scss/

What I tried that did not work:
I uncommented the @import line in the chunk. I assumed this would work as the plugin would know where to find the file. But did not work.
I added the full path in the @import statement.
I tried the above with the [[++assets_url]] placeholder and the [[++assets_path]] placeholder.
I tried adding the relative path (in the custom property set I'm using) in scss_import_paths , and tried the full path.
I also tried the above with the [[++assets_url]] placeholder, and the [[++assets_path]] placeholder.
Lastly I tried importing a different test.scss file that I placed in the custom folder that had been created when the minified css file was first made.

In all cases the minified file just shows the @import statement exactly as typed in the chunk, rather than actually importing the file contents. What am I missing?

@sepiariver
Copy link
Owner

Please provide a screenshot of your Plugin Settings view :)

@sepiariver
Copy link
Owner

(And ensure that the “process placeholders” checkbox is enabled)

@LucyI
Copy link
Author

LucyI commented May 6, 2022

Here are some screenshots. Everything is back to the default except for the custom property set with process placeholders set and the custom chunk.
Custom Property Set:
c-20220505-1251
Custom Chunk:
c-20220505-1252
Default directory structure:
c-20220505-1253

@LucyI LucyI closed this as completed May 6, 2022
@LucyI
Copy link
Author

LucyI commented May 6, 2022

CSS compiled:
c-20220505-1255

@LucyI LucyI reopened this May 6, 2022
@LucyI
Copy link
Author

LucyI commented May 6, 2022

Sorry YJ, closed this by accident.

I can make you a login to the site if that's helpful.

@sepiariver
Copy link
Owner

Ok great let me see if I can reproduce locally and if not I’ll reach out for credentials :)

thank you!

@LucyI
Copy link
Author

LucyI commented May 6, 2022

No, thank you!!!

@AdamDSherman
Copy link

AdamDSherman commented Mar 13, 2023

Hi there, just wanted to follow up on this as I am also having this same issue.

UPDATE:

Discovered it was mod_rewrite preventing me from updating the plugin properties.

@sepiariver
Copy link
Owner

Well, it has been a DISGRACEFULLY long time since this thread was opened, and I'm very sorry for not having gotten around to it sooner. As it happens @matdave submitted a large and very nice pull request that has resulted in a new version 5.3.0 being released in the Extras repo tonight.

I did test the import paths and it does work, like this: [[++assets_path]]components/csssweet/scss/ with the "Preprocess tags in chunk" checkbox enabled. Please ensure to save the property set, and also that the Plugin events are firing with respect to the property set configured.

Please try out the new version and let me know if this issue continues. That is, if you're still using cssSweet, sheesh it's been a year almost. Apologies again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants