Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove conda-env name #45

Closed
edmundmiller opened this issue Nov 30, 2023 · 7 comments
Closed

Add option to remove conda-env name #45

edmundmiller opened this issue Nov 30, 2023 · 7 comments
Assignees

Comments

@edmundmiller
Copy link

Getting this:

nf-core/modules/bowtie/build:bowtie_build--7d5920d114506960

And I'd love to see

nf-core/modules/bowtie/build:7d5920d114506960

Not a top priority just a thought.

@edmundmiller
Copy link
Author

It looks like it's --image?

@munishchouhan
Copy link
Member

@edmundmiller
Copy link
Author

edmundmiller commented Nov 30, 2023

Could we do something like:

        if( condaFile && (prefix=guessCondaRecipeName(condaFile)) ) {
+           tag = "${repo : normaliseTag(prefix) + "--" ? "" }${id}"
-           tag = "${normaliseTag(prefix)}--${id}"
        }        

@munishchouhan munishchouhan self-assigned this Dec 20, 2023
@pditommaso
Copy link
Contributor

What's the rationale of stripping the package name? it makes much more readble

@edmundmiller
Copy link
Author

What's the rationale of stripping the package name? it makes much more readble

I agree it does! Just the optionality because it's redundant if there's a freeze repo.

Probably not a priority though, just a few repeated words.

@pditommaso
Copy link
Contributor

This will be solved by seqeralabs/wave#395

@pditommaso
Copy link
Contributor

Closing in favour of #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants