diff --git a/packages/server/src/cache.ts b/packages/server/src/cache.ts index 9a41dedf5..1bdec878b 100644 --- a/packages/server/src/cache.ts +++ b/packages/server/src/cache.ts @@ -5,7 +5,6 @@ import createMsgpack from 'msgpack5' import * as R from 'ramda' import Redlock from 'redlock' -import { captureErrorEvent } from './error-event' import { Priority, Cache, CacheEntry } from '~/context/cache' import { timeToMilliseconds, Time, Timer } from '~/timer' import { FunctionOrValue, isUpdateFunction } from '~/utils' @@ -28,14 +27,6 @@ export function createCache({ timer }: { timer: Timer }): Cache { if (times * delay > 300_000) throw new Error('Redis connection timed out') return delay }, - maxRetriesPerRequest: 3, - }) - - client.on('error', (error) => { - captureErrorEvent({ - error, - location: 'cache', - }) }) const lockManagers: Record = { @@ -43,7 +34,7 @@ export function createCache({ timer }: { timer: Timer }): Cache { retryCount: 0, }), [Priority.High]: createLockManager({ - retryCount: 5, + retryCount: 10, }), } @@ -187,13 +178,6 @@ function createLockManager({ retryCount: number }): LockManager { const client = new Redis(process.env.REDIS_URL) - client.on('error', (error) => { - captureErrorEvent({ - error, - location: 'Cache lockManager', - }) - client.disconnect() - }) const redlock = new Redlock([client], { retryCount }) return { diff --git a/packages/server/src/cached-resolver.ts b/packages/server/src/cached-resolver.ts index d4574ddf9..8a4a632d3 100644 --- a/packages/server/src/cached-resolver.ts +++ b/packages/server/src/cached-resolver.ts @@ -15,12 +15,7 @@ export function createCachedResolver( __typename: 'CachedResolver', async resolveWithDecoder(customDecoder, payload, context) { const key = spec.getKey(payload) - const cacheValue = await context.cache - .get({ key, maxAge }) - .catch(() => { - // probably we don't have a connection to redis - return O.none - }) + const cacheValue = await context.cache.get({ key, maxAge }) if (O.isSome(cacheValue)) { const cacheEntry = cacheValue.value @@ -43,16 +38,13 @@ export function createCachedResolver( const value = await spec.getCurrentValue(payload, context) if (customDecoder.is(value)) { - await context.cache - .set({ - key, - value, - source: 'API: From a call to a data source', - ttlInSeconds, - }) - .catch(() => { - // probably we don't have a connection to redis - }) + await context.cache.set({ + key, + value, + source: 'API: From a call to a data source', + ttlInSeconds, + }) + return value } else { throw new InvalidCurrentValueError({ diff --git a/packages/server/src/internals/swr-queue.ts b/packages/server/src/internals/swr-queue.ts index 388f2997a..3101f53b4 100644 --- a/packages/server/src/internals/swr-queue.ts +++ b/packages/server/src/internals/swr-queue.ts @@ -64,7 +64,6 @@ export function createSwrQueue({ isWorker: false, removeOnFailure: true, removeOnSuccess: true, - autoConnect: false, }) queue.on('error', (error) => {