Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenHarmony support to Spidermonkey for logging #487

Closed
jschwe opened this issue Jul 30, 2024 · 2 comments
Closed

Add OpenHarmony support to Spidermonkey for logging #487

jschwe opened this issue Jul 30, 2024 · 2 comments

Comments

@jschwe
Copy link
Member

jschwe commented Jul 30, 2024

I have no idea how easy it would be to upstream changes like this, but the problem I'm facing is the following:

When spidermonkey encounters an error (E.g. a failed assertion), it prints to stderr.
I have a PR on the servo side which redirects stderr to the hilog logging system, but that uses a 2nd thread, which means that if the user sees the failed assertion is highly racy (does the logging thread log before the process dies).
Spidermonkey solves this on android by directly using __android_log_print and friends. We would probably need something like that too for OpenHarmony.

I guess Firefox currently probably does not have any plans to support OpenHarmony,but I'm wondering if they would accept pull requests adding OH support like above?

@jdm
Copy link
Member

jdm commented Jul 30, 2024

Best way to find out is to ask in their Matrix channel: https://chat.mozilla.org/#/room/#spidermonkey:mozilla.org

@jschwe
Copy link
Member Author

jschwe commented Aug 19, 2024

Closing this issue since we already resolved this locally. Opened #498 to track upstreaming of the patches

@jschwe jschwe closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants