Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SGKIT_DISABLE_NUMBA_CACHE=1 by default #1156

Open
jeromekelleher opened this issue Dec 14, 2023 · 3 comments
Open

Set SGKIT_DISABLE_NUMBA_CACHE=1 by default #1156

jeromekelleher opened this issue Dec 14, 2023 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@jeromekelleher
Copy link
Collaborator

This is causing persistent problems, with cryptic segfaults being really really hard to debug with Dask (I just lost a whole morning to it!).

We have to turn off the numba cache until this is sorted out somehow.

@jeromekelleher jeromekelleher added the bug Something isn't working label Dec 14, 2023
@jeromekelleher jeromekelleher added this to the 0.8.0 release milestone Dec 14, 2023
@tomwhite
Copy link
Collaborator

Is changing the default in https://github.com/pystatgen/sgkit/blob/main/sgkit/accelerate.py#L6 sufficient?

@jeromekelleher
Copy link
Collaborator Author

jeromekelleher commented Dec 18, 2023

I guess a warning if numba cache is enabled also? It's a horrible gotcha.

@jeromekelleher
Copy link
Collaborator Author

Partially addressed ion #1191.

To fully address I think we probably need to undocument this variable by removing the mention to it in the docs, and maybe add some comments in the source laying out the issue. Plus update to the changelog.

@jeromekelleher jeromekelleher modified the milestones: 0.8.0 release, 0.8.1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants