Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly find out Dart_PostCObject function pointer, instead of manually letting Dart to call Rust's store_dart_post_cobject? #10

Open
fzyzcjy opened this issue Oct 2, 2021 · 2 comments
Open

Directly find out Dart_PostCObject function pointer, instead of manually letting Dart to call Rust's store_dart_post_cobject? #10

fzyzcjy opened this issue Oct 2, 2021 · 2 comments

Comments

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Oct 2, 2021 •
edited
Loading

Hi thanks for the lib! Looking at https://github.com/dart-lang/sdk/blob/master/runtime/include/dart_api_dl.h , I guess a C++ programmer will simply #include this header and then use the extern Dart_PostCObject_Type Dart_PostCObject_DL; directly. So what about removing store_dart_post_cobject and directly do that?

I can make a PR.

related: dart-lang/sdk#47356
@shekohex
Copy link
Owner

shekohex commented Oct 2, 2021

can you explain more? what are you trying to achieve here?

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 2, 2021

I find it probably not feasible. So please ignore this issue until I get reply from the related dart sdk issue.

By the way, #12 is NOT the same as this issue. That PR is merely using a lib to remove a unsafe call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fzyzcjy @shekohex