Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Build Controller Has Permission to Modify CRDs #1789

Open
1 task done
adambkaplan opened this issue Jan 27, 2025 · 0 comments
Open
1 task done

[BUG] Build Controller Has Permission to Modify CRDs #1789

adambkaplan opened this issue Jan 27, 2025 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@adambkaplan
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

Kubernetes 1.30.0

Shipwright Version

v0.14.0

Current Behavior

In #1646, the build controller was granted permission to patch CustomResourceDefinitions. This presents a minor security risk due to the controller having excessive permissions (violates principle of least privilege).

Admins using the version migrator should create a dedicated service account and RBAC for this purpose.

Expected Behavior

The build controller should not have permission to modify CRDs.

Steps To Reproduce

  1. Install Shipwright Builds v0.14.0.
  2. Inspect the RBAC granted to the build controller's service account.

Anything else?

No response

@adambkaplan adambkaplan added the kind/bug Categorizes issue or PR as related to a bug. label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: No status
Development

No branches or pull requests

1 participant