Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhino caches API rate limite responses #13

Open
GuySartorelli opened this issue Feb 20, 2024 · 0 comments
Open

Rhino caches API rate limite responses #13

GuySartorelli opened this issue Feb 20, 2024 · 0 comments

Comments

@GuySartorelli
Copy link
Member

Found when running the merge-ups task, but likely happens with any of them.

If you forget to add the github token in your .env file (or for any other reason you hit rate limits), the rate limit response is cached in the database. Rerunning the task after adding the token (or waiting for the rate limit timeout) fails, because Rhino fetches the cached response and packs a sad because it thinks you're still hitting the rate limit.

I also didn't get a clear error message when running the task - I had to debug to find out why I was getting server errors suddenly.

Acceptance criteria

  • Failed API responses (including but not limited to rate limiting) are not cached in the database
  • Failed API requests result in a clear message being displayed in the browser (for tasks) or in the job message list (for queued jobs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant