Skip to content

Commit

Permalink
API Remove deprecated extension hooks
Browse files Browse the repository at this point in the history
We don't really have a way to deprecate these per-se, but they were
removed in other admin sections already so it's time to remove them from
here as well.
  • Loading branch information
GuySartorelli committed Jan 6, 2025
1 parent 1d5cecb commit 7a30660
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
1 change: 0 additions & 1 deletion code/LeftAndMain.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
use SilverStripe\Model\ArrayData;
use SilverStripe\View\Requirements;
use SilverStripe\View\SSViewer;
use SilverStripe\Dev\Deprecation;

/**
* LeftAndMain is the parent class of all the two-pane views in the CMS.
Expand Down
1 change: 0 additions & 1 deletion code/ModalController.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Forms\Form;
use SilverStripe\Dev\Deprecation;

/**
* Parent controller for all CMS-global modals
Expand Down
13 changes: 0 additions & 13 deletions code/ModelAdmin.php
Original file line number Diff line number Diff line change
Expand Up @@ -321,19 +321,6 @@ protected function getGridFieldConfig(): GridFieldConfig
->addComponent($exportButton)
->addComponents(Injector::inst()->createWithArgs(GridFieldPrintButton::class, ['buttons-before-left']));

// Remove default and add our own filter header with extension points
// to retain API until deprecation in 5.0
$config->removeComponentsByType(GridFieldFilterHeader::class);
$config->addComponent(Injector::inst()->createWithArgs(GridFieldFilterHeader::class, [
false,
function ($context) {
$this->extend('updateSearchContext', $context);
},
function ($form) {
$this->extend('updateSearchForm', $form);
}
]));

if (!$this->showSearchForm ||
(is_array($this->showSearchForm) && !in_array($this->getModelClass(), $this->showSearchForm ?? []))
) {
Expand Down

0 comments on commit 7a30660

Please sign in to comment.