Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken builds #1656

Closed
GuySartorelli opened this issue Jan 23, 2024 · 1 comment
Closed

Broken builds #1656

GuySartorelli opened this issue Jan 23, 2024 · 1 comment
Assignees
@GuySartorelli

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Jan 23, 2024 •
edited
Loading

https://github.com/silverstripe/silverstripe-admin/actions/runs/7618883901/job/20750916959

BulkLoader is being initialised with the tab name instead of the class name when a custom tab name is provided.

https://github.com/silverstripe/silverstripe-admin/actions/runs/7618820966/job/20753517379

There's ambiguity resulting in the wrong item being deleted

PRs
@GuySartorelli GuySartorelli mentioned this issue Jan 23, 2024
Merged
7 tasks
@GuySartorelli GuySartorelli self-assigned this Jan 23, 2024
@GuySartorelli GuySartorelli mentioned this issue Jan 23, 2024
Merged
@GuySartorelli
Copy link
Member Author

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GuySartorelli