ENH Refactor sudo mode components to reduce code reuse #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Feb 20, 2025
client/src/components/SudoModePasswordField/SudoModePasswordField.js
Outdated
Show resolved
Hide resolved
GuySartorelli
force-pushed
the
pulls/2/cleanup-sudo
branch
from
dac2520 to
91b4666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the HOC locally by reinstating the HOC to MFA (i.e. undo the JS changes from silverstripe/silverstripe-mfa#587) and removing the calls to
requireSudoMode().Comparison of visual appearance is below. Functionality should also be identical to what it was without this PR.
If anyone customised the HOC styling or was relying on those selectors they'll be out of luck - I can't be assed updating the new component to use the old css class names so I used its css instead of what was there prior to the recent work.
OLD look
NEW look
Issue