API Refactor SiteTree filtering to work like GridField filters #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
GuySartorelli
force-pushed
the
pulls/6.0/refactor-sitetree-filter
branch
2 times, most recently
from
7d991c5 to
be997fd
Compare
GuySartorelli
force-pushed
the
pulls/6.0/refactor-sitetree-filter
branch
3 times, most recently
from
44daef5 to
e8297af
Compare
GuySartorelli
force-pushed
the
pulls/6.0/refactor-sitetree-filter
branch
6 times, most recently
from
ce54bb9 to
85c32a0
Compare
GuySartorelli
force-pushed
the
pulls/6.0/refactor-sitetree-filter
branch
from
85c32a0 to
7243da7
Compare
CMSMain uses an entirely separate code path for building the filter form and for the actual filter functionality compared with the gridfield filter used literally everywhere else in the CMS. This aims to unify the two as much as possible, so that filtering pages in CMSMain is the same as filtering everywhere else.
GuySartorelli
force-pushed
the
pulls/6.0/refactor-sitetree-filter
branch
from
7243da7 to
cf1ff64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMSMain uses an entirely separate code path for building the filter form and for the actual filter functionality compared with the gridfield filter used literally everywhere else in the CMS.
This aims to unify the two as much as possible, so that filtering pages in CMSMain is the same as filtering everywhere else.
It also generalises it which will help to unlock #2951
Issue
CMSMain/HierarchyModelAdmin#2949