Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: better anchors from blocks => provide human readable value #1320

Open
wants to merge 1 commit into
base: 5
Choose a base branch
from

Conversation

sunnysideup
Copy link
Contributor

Description

Right now, when you get a list of anchors from an elemental, the first anchor will be something like: ['e1123' => 'e1123']
This does not make any sense for the user.

This is the first step in correcting this by changing it to ['e1123] => 'Title of block goes here']

Manual testing steps

  • This is only the first step towards having better anchors. This provides better anchors, after we may need to change other modules to make it work. However, in the project I tried it, it already worked straight away!

Issues

I could not find an issue relating to it.

Pull request checklist

  • The target branch is correct (I think - used the default one).
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions. Not 100%, but a linter should be able to clean that up.
  • This change is covered with tests (or tests aren't necessary for this change). Not yet.
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release. Not Applicable, AFAIK.
  • CI is green. I am yet to check that.

…able value

Right now, when you get a list of anchors from an elemental, the first anchor will be something like:
['e1123' => 'e1123']
This does not make any sense for the user.

This is the first step in correcting this by changing it to 
['e1123] => 'Title of block goes here']
@sunnysideup sunnysideup changed the title ENH: better anchors from blocks with human readable value ENH: better anchors from blocks => provide human readable value Feb 24, 2025
@GuySartorelli
Copy link
Member

Please create an issue for this.

Please also target the 6.0 branch, as the CMS 5.4 beta release process has begun which means we can't accept new features or enhancements for CMS 5.

@GuySartorelli
Copy link
Member

Please also look at the failed CI which indicates a problem in your code, and also update any relevant unit or behat tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants