Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataObjectInterface #11504

Closed
2 tasks
emteknetnz opened this issue Dec 9, 2024 · 1 comment
Closed
2 tasks

Remove DataObjectInterface #11504

emteknetnz opened this issue Dec 9, 2024 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Dec 9, 2024

DataObjectInterface is a pointless interface that only implements a tiny proportion of DataObjects API

Acceptance criteria

  • DataObjectInterface is removed
  • Any code that references DataObjectInterface is updated

CMS 5 PRs

After merging assign back to Steve to merge-up and rebase

CMS 6 kitchen sink CI

^ Unit test failure is unrelated - will be fixed by silverstripe/silverstripe-asset-admin#1542
! However behat test in not unrelated

CMS 6 PRs

@emteknetnz
Copy link
Member Author

Not proceeding as ArbitraryDataModel in frameworktest, which was intended to simulate using GridField as an intermediary to manage third API data (read and write), highlighted the fact that DataObjectInterface does have a purpose, it's just badly named. It should be called something more along the lines of 'WritableDataInterface' as it's not DataObject specific.

This work also highlighed that setCastedField() is poorly named, it really just be rolled into setField() or probably better simply setValue()

@emteknetnz emteknetnz reopened this Feb 12, 2025
@emteknetnz emteknetnz closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant