Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix unit test providers #11615

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Feb 13, 2025

Fixes https://github.com/silverstripe/silverstripe-framework/actions/runs/13299837085/job/37139181714?pr=11602

1) SilverStripe\Forms\Tests\GridField\GridFieldPrintButtonTest::testHandlePrintEscaping
The data provider specified for SilverStripe\Forms\Tests\GridField\GridFieldPrintButtonTest::testHandlePrintEscaping is invalid
Data Provider method SilverStripe\Forms\Tests\GridField\GridFieldPrintButtonTest::provideHandlePrintEscaping() is not static

/home/runner/work/silverstripe-framework/silverstripe-framework/tests/php/Forms/GridField/GridFieldPrintButtonTest.php:199
 There were 2 PHPUnit test runner deprecations:

1) Metadata found in doc-comment for method SilverStripe\Forms\Tests\GridField\GridFieldPrintButtonTest::testHandlePrintEscaping(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

2) Metadata found in doc-comment for method SilverStripe\ORM\Tests\DataObjectTest::testProvideI18nEntities(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

And https://github.com/silverstripe/silverstripe-framework/actions/runs/13316490516/job/37191706970

 PHP Fatal error:  Declaration of SilverStripe\ORM\DataObject@anonymous::classDescription() must be compatible with SilverStripe\ORM\DataObject::classDescription(): ?string in /home/runner/work/silverstripe-framework/silverstripe-framework/tests/php/ORM/DataObjectTest.php on line 2871

Issue

@emteknetnz emteknetnz merged commit 77cd041 into silverstripe:6.0 Feb 13, 2025
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/fix-tests branch February 13, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants