ENH Disable temporary sudo mode after login #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
from
efb2feb to
60f4ea7
Compare
5 tasks
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
2 times, most recently
from
63944f5 to
cfdacbf
Compare
emteknetnz
commented
Feb 11, 2025
behat.yml
Outdated
| @@ -15,6 +15,7 @@ default: | |||
| - SilverStripe\Framework\Tests\Behaviour\CmsUiContext | |||
| - SilverStripe\BehatExtension\Context\BasicContext | |||
| - SilverStripe\BehatExtension\Context\EmailContext | |||
| - SilverStripe\BehatExtension\Context\FixtureContext | |||
There was a problem hiding this comment.
Required so that can use Given I add an extension in the feature file
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
3 times, most recently
from
772d5d4 to
8e64049
Compare
GuySartorelli
requested changes
Feb 13, 2025
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
from
8e64049 to
920ee32
Compare
GuySartorelli
requested changes
Feb 18, 2025
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
2 times, most recently
from
a9768b8 to
fc59651
Compare
GuySartorelli
approved these changes
Feb 19, 2025
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
from
fc59651 to
2820fc9
Compare
|
Have made a push to remove the HOC from the mfa field in the cms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1898