Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX update defensive check on tags field method #78

Merged

Conversation

HeyImPhil
Copy link
Contributor

@HeyImPhil HeyImPhil commented Jan 24, 2024

Description

If a page type is removed and the page type is orphaned. The report will fail when it is exported to CSV on this data object because it doesn't find the Terms() on SiteTree.

Manual testing steps

  1. Delete a page type that is in use (Pages are currently assigned to it)
  2. Generate report
  3. Export report
  4. The report should be generated and downloaded

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@HeyImPhil HeyImPhil changed the title Update defensive check on tags field method FIX update defensive check on tags field method Jan 24, 2024
@HeyImPhil HeyImPhil force-pushed the bugfix/orphaned-page-types branch from 5f75439 to b3b8908 Compare January 24, 2024 01:38
@HeyImPhil HeyImPhil changed the base branch from 3 to 3.4 January 24, 2024 01:40
@HeyImPhil HeyImPhil force-pushed the bugfix/orphaned-page-types branch from b3b8908 to e6638ec Compare January 24, 2024 03:32
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit ed176f7 into silverstripe:3.4 Jan 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants