ENH Remove use of ChangeSets from RecursivePublishable #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/3.0/remove-changeset
branch
3 times, most recently
from
6c26cdc to
16c08ac
Compare
emteknetnz
force-pushed
the
pulls/3.0/remove-changeset
branch
from
16c08ac to
d4a838d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #472
This isn't quite working. Conceptually it seems correct, but there's something weird happening in SiteTree where the numbers reported for $this->Version are different, which almost seems like their wrong before this PR, though I'm not sure
e.g. SiteTreeTest::testGetCMSActionsWithoutForms() causes SiteTree::getCMSActions() has a difference as to whether it provides an 'action_rollback' action
I was hoping that this PR would be a quick win and I planned to close it if things got to difficult. It's at that point now so I'm closing this.