Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Update externals list for TinyMCE migration #80

Open
wants to merge 1 commit into
base: 3.0
Choose a base branch
from
Open

ENH Update externals list for TinyMCE migration #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions js/externals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ module.exports = (ENV, PATHS, module) => {
'lib/schemaFieldValues': 'schemaFieldValues',
'lib/ShortcodeSerialiser': 'ShortcodeSerialiser',
'lib/SilverStripeComponent': 'SilverStripeComponent',
'lib/TinyMCEActionRegistrar': 'TinyMCEActionRegistrar',
'lib/urls': 'ssUrlLib',
'lib/withRouter': 'withRouter',
'state/breadcrumbs/BreadcrumbsActions': 'BreadcrumbsActions',
Expand Down Expand Up @@ -118,8 +117,17 @@ module.exports = (ENV, PATHS, module) => {
},
'silverstripe/asset-admin/js': {
// bundles/bundle.js
'containers/InsertEmbedModal/InsertEmbedModal': 'InsertEmbedModal',
'components/InsertEmbedModal/InsertEmbedModal': 'InsertEmbedModal',
Comment on lines -121 to +120
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this was just wrong the whole time - but no need to fix in CMS 5, because anyone using it there will already be using this (technically incorrect) import and it'll be working.

'containers/InsertMediaModal/InsertMediaModal': 'InsertMediaModal',
'state/modal/AssetAdminModalActions': 'AssetAdminModalActions',
},
'silverstripe/cms/js': {
// bundles/bundle.js
'state/anchorSelector/AnchorSelectorActions': 'AnchorSelectorActions',
},
'silverstripe/htmleditor-tinymce/js': {
// bundle.js
'lib/TinyMCEActionRegistrar': 'TinyMCEActionRegistrar',
},
// Provided by silverstripe/admin's i18n.js, but doesn't use expose-loader
i18n: 'i18n',
Expand Down