This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Naming convention clashes #65

Open

ahashibon opened this issue Jan 18, 2016 · 0 comments

ahashibon commented Jan 18, 2016

the naming of the internal-interface and wrapper here:

simphony-openfoam/openfoam-interface/internal-interface/wrapper/

The internal in "internal-interface" conflicts, and confuses with the notion of internal SimPhoNy (as opposed to File-IO) wrapper. Please consider renaming to, e.g., simphony-foam or foam-adaptor, or ...
The name "wrapper: in this context is also misleading. The "wrapper" should be preserved for the public interface (i.e., currently the ABCModellingEngine). However if you have a good reason to leave this this way, lets discuss.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.