Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest-runner from build-system.requires #1659

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

musicinmybrain
Copy link
Contributor

The pytest-runner package has been deprecated upstream for some time, and the project is now archived:
https://github.com/pytest-dev/pytest-runner/tree/v6.0.1?tab=readme-ov-file#deprecation-notice

Furthermore, the "setup.py test" command was removed in setuptools 72: https://github.com/pypa/setuptools/blob/v75.8.0/NEWS.rst#v7200

This does not affect running the tests with pytest.

Summary

Removes the dependency on the deprecated pytest-runner package, which – since this project does not use the deprecated/removed setup.py test for running tests and does not use the deprecated tests_require for expressing test dependencies – was no longer doing anything useful anyway.

Testing

Run the tests, in any of the usual ways, and observe that everything still works.

Consult the linked deprecation notice for pytest-runner.

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

The `pytest-runner` package has been deprecated upstream for some time,
and the project is now archived:
https://github.com/pytest-dev/pytest-runner/tree/v6.0.1?tab=readme-ov-file#deprecation-notice

Furthermore, the "setup.py test" command was removed in setuptools 72:
https://github.com/pypa/setuptools/blob/v75.8.0/NEWS.rst#v7200

This does not affect running the tests with pytest.
Copy link

Thanks for the contribution! Before we can merge this, we need @musicinmybrain to sign the Salesforce Inc. Contributor License Agreement.

@musicinmybrain
Copy link
Contributor Author

I signed the CLA, although things seem a bit crashy (for example, https://cla.salesforce.com/status/slackapi/python-slack-sdk/pull/1659 produces an error), so who knows if the automation will ever figure that out.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (2cac36b) to head (44508df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1659   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         113      113           
  Lines       12802    12802           
=======================================
  Hits        10928    10928           
  Misses       1874     1874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter of fact everything does still work 💯

Thank you for the contribution 🚀

@WilliamBergamin WilliamBergamin added the tests M-T: Testing work only label Feb 24, 2025
@WilliamBergamin WilliamBergamin merged commit 56f8c84 into slackapi:main Feb 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants