Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test data for date conversion #153

Open
roozbehp opened this issue Apr 4, 2024 · 3 comments
Open

Add test data for date conversion #153

roozbehp opened this issue Apr 4, 2024 · 3 comments

Comments

@roozbehp
Copy link

roozbehp commented Apr 4, 2024

I just typed in the leap year data from the Iranian calendar authority and put it at: https://github.com/roozbehp/persiancalendar/blob/main/kabise.txt

It would be great if automatic tests could be added based on that data to this project. (I expect all of them to pass.)

@slashmili
Copy link
Owner

Great idea!

only that the test will be for jalali-core as the algorithm resides there

@roozbehp
Copy link
Author

roozbehp commented Apr 5, 2024

You also have part of that algorithm here, in your isleap() method. I recommend either having it here or in both projects.

@slashmili
Copy link
Owner

fair point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants