Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the need for using PYTHONPATH for sudo-ing into denoise #263

Open
smarr opened this issue Sep 5, 2024 · 1 comment
Open

Avoid the need for using PYTHONPATH for sudo-ing into denoise #263

smarr opened this issue Sep 5, 2024 · 1 comment
Labels

Comments

@smarr
Copy link
Owner

smarr commented Sep 5, 2024

I think it's a potential source for bugs to rely on PYTHONPATH and the rebench-denoise wrapper installed by pip.

We probably get more reliable results by having our own wrapper script for denoise or possibly even running it directly with the same python used for rebench.
We do know the path were we find denoise.py, and could adapt sys.path as needed reliably without modifying the environment.

This is a followup to the changes in #260.

@smarr smarr added the Feature label Sep 5, 2024
@smarr
Copy link
Owner Author

smarr commented Oct 1, 2024

It looks like this is indeed an issue in the ReBenchDB integration tests:

https://github.com/smarr/ReBenchDB/actions/runs/11124536077/job/30910272896#step:11:54

Minimizing noise with rebench-denoise failed
    possibly causing benchmark results to vary more.
    Error: Traceback (most recent call last):
  File "/home/runner/.local/bin/rebench-denoise", line 5, in <module>
    from rebench.denoise import main_func
ModuleNotFoundError: No module named 'rebench'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant