Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split -f flag into separate options: include results from failures vs exitcode handling #285

Open
smarr opened this issue Jan 29, 2025 · 0 comments
Labels

Comments

@smarr
Copy link
Owner

smarr commented Jan 29, 2025

Currently, the -f both means:

  1. that we include data from failing runs, which can be caused either by benchmarks aborting or because the validation of results fails or output indicates other issues

  2. that the rebench exit code indicates no failure

We may want to separate these concerns out.

It might be useful to have a --dont-fail option, just to keep the exit code 0.
Where --faulty is only about including data from runs that indicate some issue.

Requested by @OctaveLarose

@smarr smarr added the Feature label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant