Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change naming convention #16

Open
oguzhanunlu opened this issue Feb 18, 2022 · 2 comments
Open

Change naming convention #16

oguzhanunlu opened this issue Feb 18, 2022 · 2 comments

Comments

@oguzhanunlu
Copy link

Issues with current convention:

1 - It prevents running event-generator in multiple instances for the same target
2 - It doesn't allow more than 9999 files, as it formats based on 4 digits

@istreeter
Copy link
Contributor

Hey @oguzhanunlu I agree with point 1, but I cannot re-produce point 2.

The files are indeed based on 4 digits to start with, but the 10,000th file is called raw_10000.gz and the 100,000th file is called raw_100000.gz.

@oguzhanunlu
Copy link
Author

oguzhanunlu commented Feb 23, 2022

You're right @istreeter , that bug was pre-0.2.0, it is fixed here in 0.2.0 release. Pre-0.2.0 it'd lead to java.lang.IllegalArgumentException: count is negative when num of files exceeds 9999.

As you pointed we have different convention up to 4 digits, e.g. having raw_10000.gz and raw_0001.gz doesn't look consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants