Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused variable quickfix is broken #218

Open
mkaput opened this issue Jan 27, 2025 · 0 comments · May be fixed by #242
Open

Unused variable quickfix is broken #218

mkaput opened this issue Jan 27, 2025 · 0 comments · May be fixed by #242
Assignees
@Draggu
Labels
bug Something isn't working

Comments

@mkaput
Copy link
Member

mkaput commented Jan 27, 2025

Problem

citing @0xLucqs:

the code action to rename unused var from unused to _unused is broken it now replaces the whole var name with _

Steps

No response

Possible Solution(s)

No response

Notes

No response

Scarb Version
@mkaput mkaput added the bug Something isn't working label Jan 27, 2025
@mkaput mkaput moved this to Triage in CairoLS Jan 27, 2025
@mkaput mkaput added this to CairoLS Jan 27, 2025
@Arcticae Arcticae moved this from Triage to Todo in CairoLS Jan 29, 2025
Draggu added a commit that referenced this issue Jan 29, 2025
@Draggu
Add tests for unused variable quickfix
cb1f0ee 
These tests are incorrect because unused variable quickfix is broken #218.
Will be fixed later.

commit-id:ed657c7e
@Draggu Draggu mentioned this issue Jan 29, 2025
Merged
Draggu added a commit that referenced this issue Feb 1, 2025
@Draggu
WIP Fix unsued variable code code action
46079f9 
Fix #218
Draggu added a commit that referenced this issue Feb 1, 2025
@Draggu
WIP Fix unsued variable code code action
eaa57a8 
Fix #218
Draggu added a commit that referenced this issue Feb 1, 2025
@Draggu
WIP Fix unsued variable code code action
b2979bf 
Fix #218
@Draggu Draggu linked a pull request Feb 1, 2025 that will close this issue
Open
@Draggu Draggu linked a pull request Feb 1, 2025 that will close this issue
Fix unsued variable code code action #242
Open
@Draggu Draggu moved this from Todo to In Progress in CairoLS Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Draggu Draggu

Labels
bug Something isn't working
Projects
CairoLS
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unsued variable code code action software-mansion/cairols
2 participants
@mkaput @Draggu