From 9cbf8d7806bfe16bec2d95158ca48457c26eebd0 Mon Sep 17 00:00:00 2001 From: Filip Haftek Date: Tue, 4 Feb 2025 13:07:05 +0100 Subject: [PATCH 1/2] fix: frontend PodDisruptionBudget --- .../frontend/sourcegraph-frontend.PodDisruptionBudget.yaml | 5 +++-- charts/sourcegraph/tests/podDisruptionBudget_test.yaml | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/charts/sourcegraph/templates/frontend/sourcegraph-frontend.PodDisruptionBudget.yaml b/charts/sourcegraph/templates/frontend/sourcegraph-frontend.PodDisruptionBudget.yaml index 35d4c0a4..db2b6930 100644 --- a/charts/sourcegraph/templates/frontend/sourcegraph-frontend.PodDisruptionBudget.yaml +++ b/charts/sourcegraph/templates/frontend/sourcegraph-frontend.PodDisruptionBudget.yaml @@ -6,6 +6,7 @@ metadata: spec: {{- toYaml .Values.frontend.podDisruptionBudget | nindent 2 }} selector: - {{- include "sourcegraph.selectorLabels" . | nindent 4 }} - app: sourcegraph-frontend + matchLabels: + {{- include "sourcegraph.selectorLabels" . | nindent 6 }} + app: sourcegraph-frontend {{- end }} diff --git a/charts/sourcegraph/tests/podDisruptionBudget_test.yaml b/charts/sourcegraph/tests/podDisruptionBudget_test.yaml index 3f8c3a32..f83ccf5c 100644 --- a/charts/sourcegraph/tests/podDisruptionBudget_test.yaml +++ b/charts/sourcegraph/tests/podDisruptionBudget_test.yaml @@ -13,3 +13,6 @@ tests: - equal: path: spec.minAvailable value: 1 + - equal: + path: spec.selector.matchLabels.app + value: sourcegraph-frontend From 25329725360fd1a15d5d324a2b71e63e5ec296f7 Mon Sep 17 00:00:00 2001 From: Filip Haftek Date: Tue, 4 Feb 2025 14:14:37 +0100 Subject: [PATCH 2/2] changelog --- charts/sourcegraph/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/charts/sourcegraph/CHANGELOG.md b/charts/sourcegraph/CHANGELOG.md index e1f7848c..2614bc39 100644 --- a/charts/sourcegraph/CHANGELOG.md +++ b/charts/sourcegraph/CHANGELOG.md @@ -8,6 +8,8 @@ Use `**BREAKING**:` to denote a breaking change ## Unreleased +- Fix Pod Disruption Budget for sourcegraph-frontend + ## 5.10.0 - Updated OpenTelemetry collector and agent images to run as non-root users [#543](https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/543)