Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fails to find GoogleTest #375

Open
bavulapati opened this issue Feb 8, 2025 · 5 comments
Open

make fails to find GoogleTest #375

bavulapati opened this issue Feb 8, 2025 · 5 comments

Comments

@bavulapati
Copy link

Here the error observed:

CMake Error at vendor/core/cmake/FindGoogleTest.cmake:4 (add_subdirectory):
  add_subdirectory given source
  "/Users/balakrishna/sourcemeta/blaze/vendor/googletest" which is not an
  existing directory.
Call Stack (most recent call first):
  vendor/core/cmake/common/targets/googletest.cmake:19 (find_package)
  test/compiler/CMakeLists.txt:1 (sourcemeta_googletest)


CMake Error at vendor/core/cmake/FindGoogleTest.cmake:4 (add_subdirectory):
  add_subdirectory given source
  "/Users/balakrishna/sourcemeta/blaze/vendor/googletest" which is not an
  existing directory.
Call Stack (most recent call first):
  vendor/core/cmake/common/targets/googletest.cmake:19 (find_package)
  test/evaluator/CMakeLists.txt:1 (sourcemeta_googletest)


CMake Error at vendor/core/cmake/FindGoogleTest.cmake:4 (add_subdirectory):
  add_subdirectory given source
  "/Users/balakrishna/sourcemeta/blaze/vendor/googletest" which is not an
  existing directory.
Call Stack (most recent call first):
  vendor/core/cmake/common/targets/googletest.cmake:19 (find_package)
  test/evaluator/CMakeLists.txt:28 (sourcemeta_googletest)
@jviotti
Copy link
Member

jviotti commented Feb 10, 2025

What OS are you on? How are you running the project? I confirm make works fine for me in all platforms and CI agrees: https://github.com/sourcemeta/blaze/actions/runs/13206299320. Can you try a fresh clone and make and also potentially try in another system? There might be something on your specific setup triggering this

@bavulapati
Copy link
Author

What OS are you on?

MacOS Arm M1

How are you running the project?

I cloned the project. On main latest. Using make

I confirm make works fine for me in all platforms and CI agrees: https://github.com/sourcemeta/blaze/actions/runs/13206299320. Can you try a fresh clone and make and also potentially try in another system? There might be something on your specific setup triggering this

Yes, it could be specific to my setup. I'll run it on my windows machine and report back.

@bavulapati
Copy link
Author

bavulapati commented Feb 10, 2025

On Windows, it builds but tests fail.

4/5 Test #2: blaze.evaluator.....................***Exception:  14.38 sec
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\vector(122) : Assertion failed: cannot seek vector iterator after end

@jviotti
Copy link
Member

jviotti commented Feb 10, 2025

Interesting. I confirm MSVC on CI too: https://github.com/sourcemeta/blaze/actions/runs/13206299320/job/36870122133. Maybe a different version of MSVC? Sounds like a fun one to dig into for a first contribution :) I would attach WinDbg on it and see where its complaining at

@bavulapati
Copy link
Author

Interesting. I confirm MSVC on CI too: https://github.com/sourcemeta/blaze/actions/runs/13206299320/job/36870122133. Maybe a different version of MSVC? Sounds like a fun one to dig into for a first contribution :) I would attach WinDbg on it and see where its complaining at

Sure. I'll dig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants