From 1592684918a6071f18ec336a4848a5a7c8664d70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ru=20Ke=C3=AFn?= <3181182+alphasentaurii@users.noreply.github.com> Date: Fri, 26 Jul 2024 15:55:38 -0400 Subject: [PATCH] roman/ref-to-dataset-keypairs (#1055) * revert back to v1 zendesk action * updated params rmaps to include reference_to_dataset pairs. Hard set useafter to include roman prefix --- CHANGES.rst | 8 ++ crds/roman/locate.py | 2 +- crds/roman/specs/combined_specs.json | 109 +++++++++++++++--- crds/roman/specs/wfi_pars-assignwcsstep.rmap | 6 +- .../roman/specs/wfi_pars-darkcurrentstep.rmap | 6 +- crds/roman/specs/wfi_pars-dqinitstep.rmap | 6 +- .../specs/wfi_pars-exposurepipeline.rmap | 6 +- crds/roman/specs/wfi_pars-flatfieldstep.rmap | 6 +- crds/roman/specs/wfi_pars-fluxstep.rmap | 6 +- .../specs/wfi_pars-highlevelpipeline.rmap | 6 +- crds/roman/specs/wfi_pars-jumpstep.rmap | 6 +- crds/roman/specs/wfi_pars-linearitystep.rmap | 6 +- .../specs/wfi_pars-outlierdetectionstep.rmap | 7 +- crds/roman/specs/wfi_pars-photomstep.rmap | 6 +- crds/roman/specs/wfi_pars-rampfitstep.rmap | 5 +- crds/roman/specs/wfi_pars-refpixstep.rmap | 6 +- crds/roman/specs/wfi_pars-resamplestep.rmap | 6 +- crds/roman/specs/wfi_pars-saturationstep.rmap | 6 +- crds/roman/specs/wfi_pars-skymatchstep.rmap | 6 +- .../specs/wfi_pars-sourcedetectionstep.rmap | 7 +- crds/roman/specs/wfi_pars-tweakregstep.rmap | 6 +- test/certify/test_certify.py | 11 ++ .../roman/roman_wfi_pars-jumpstep_0001.asdf | 56 +++++++++ 23 files changed, 258 insertions(+), 37 deletions(-) create mode 100644 test/data/roman/roman_wfi_pars-jumpstep_0001.asdf diff --git a/CHANGES.rst b/CHANGES.rst index 8df0a2ebf..ad46ef827 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,3 +1,11 @@ +11.18.1 (unreleased) +==================== + +ROMAN +----- + +- Added reference_to_dataset keypairs for all roman parameter rmaps. Translate useafter to include 'ROMAN' prefix for all reference types (parameter refs included). Added jumpstep test file and new certify test (commented out until crds-cache-test is updated to include this). [#1055] + 11.18.0 (2024-07-26) ==================== diff --git a/crds/roman/locate.py b/crds/roman/locate.py index 64e16235a..87f4f8d87 100644 --- a/crds/roman/locate.py +++ b/crds/roman/locate.py @@ -537,7 +537,7 @@ def reference_keys_to_dataset_keys(rmapping, header): reformatted = timestamp.reformat_useafter(filename, header).split() dt_string = f"{reformatted[0]} {reformatted[1]}" - header[f"{prefix}.EXPOSURE.START_TIME"] = dt_string + header["ROMAN.META.EXPOSURE.START_TIME"] = dt_string log.verbose("reference_to_dataset output header:\n", log.PP(header), verbosity=80) diff --git a/crds/roman/specs/combined_specs.json b/crds/roman/specs/combined_specs.json index c0b0d8ad6..d1ff574a1 100644 --- a/crds/roman/specs/combined_specs.json +++ b/crds/roman/specs/combined_specs.json @@ -321,7 +321,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"006b320c237efedf59afc98275582f6bf0ed619b", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"248deffa52bc0de6d8a44139fbd561467eb8cfb6", "suffix":"pars-assignwcsstep", "text_descr":"AssignWcsStep runtime parameters", "tpn":"wfi_pars-assignwcsstep.tpn", @@ -346,7 +350,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"45f4c04f38701c5ce6da2ed234a61c9f1ae36d00", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"3cde31e615ef4b38911578908c4dfd6649601f03", "suffix":"pars-darkcurrentstep", "text_descr":"DarkCurrentStep runtime parameters", "tpn":"wfi_pars-darkcurrentstep.tpn", @@ -371,7 +379,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"dd6cf0cdeacf634a860c39cdf438a06bc27097f3", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"0d25601ddf2b43f51ed54e1660db6e2c0f6c8dd4", "suffix":"pars-dqinitstep", "text_descr":"DQInitStep runtime parameters", "tpn":"wfi_pars-dqinitstep.tpn", @@ -400,7 +412,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"07a8c2f7fe898212e56cc4854d4ff8c350b1c049", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"8a30602dce0211e962dac8988a35b3621287b564", "suffix":"pars-exposurepipeline", "text_descr":"Step parameters for ExposurePipeline", "tpn":"wfi_pars-exposurepipeline.tpn", @@ -425,7 +441,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"690afb5354f33be070cb5805053de4879a483fc1", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"fcdce6a7535888352a820f06a509bc2a28f2545c", "suffix":"pars-flatfieldstep", "text_descr":"FlatFieldStep runtime parameters", "tpn":"wfi_pars-flatfieldstep.tpn", @@ -450,7 +470,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"6f243a719f87ea2f36a7cf7b6a128ec096eae71d", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"437697f4b39b3b3b02428c237da2d63e235662fb", "suffix":"pars-fluxstep", "text_descr":"FluxStep runtime parameters", "tpn":"wfi_pars-fluxstep.tpn", @@ -479,7 +503,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"a7c65100f35a11b668721a3c6853d7ad2ed6d597", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"3658f4741e2ca45ae61dc938f096d015477f821b", "suffix":"pars-highlevelpipeline", "text_descr":"Step parameters for HighLevelPipeline", "tpn":"wfi_pars-highlevelpipeline.tpn", @@ -504,7 +532,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"2476df99dd9bd0854a2545cf70d69f0c8707ba81", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"379be600ed1097bd929fe298b46b5ed25106852a", "suffix":"pars-jumpstep", "text_descr":"JumpStep runtime parameters", "tpn":"wfi_pars-jumpstep.tpn", @@ -529,7 +561,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"c88ea40348060277a00a098c169706a43ccff15f", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"9a70026939ad0626c4326a28b3f897d7559131af", "suffix":"pars-linearitystep", "text_descr":"LinearityStep runtime parameters", "tpn":"wfi_pars-linearitystep.tpn", @@ -555,7 +591,12 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"af4b3c2a128f8c2017286e8722e6917cfdacc0bb", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE", + "META.INSTRUMENT.DETECTOR":"ROMAN.META.INSTRUMENT.DETECTOR" + }, + "sha1sum":"b80e2be97322108a798b291a24a5de5a78804b3e", "suffix":"pars-outlierdetectionstep", "text_descr":"OutlierDetectionStep runtime parameters", "tpn":"wfi_pars-outlierdetectionstep.tpn", @@ -580,7 +621,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"15643a08ae7456d3cdee7cf0dd7c00b9a00cb601", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"1de85960b6993e63d6b11d70b36d74a985588ca6", "suffix":"pars-photomstep", "text_descr":"PhotomStep runtime parameters", "tpn":"wfi_pars-photomstep.tpn", @@ -607,7 +652,10 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"1bbb7976ffd4c8695c8fd27d57cd6375eab73347", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME" + }, + "sha1sum":"517e9e9a09d86f38710398684afd0105924e15d0", "suffix":"pars-rampfitstep", "text_descr":"RampFitStep runtime parameters", "tpn":"wfi_pars-rampfitstep.tpn", @@ -632,7 +680,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"b9fe9fba7c184531656180ac2ba8ed318c34e98d", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"0b4506700cb11e419cf2f56e0146aec9ca6e6ece", "suffix":"pars-refpixstep", "text_descr":"RefPixStep runtime parameters", "tpn":"wfi_pars-refpixstep.tpn", @@ -657,7 +709,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"873e56616b3291f9efc613f467bc92902820e236", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"40a68a66c53deb1aa73cd5843db80b41dc07c94e", "suffix":"pars-resamplestep", "text_descr":"ResampleStep runtime parameters", "tpn":"wfi_pars-resamplestep.tpn", @@ -682,7 +738,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"39a0355ed18fa062b217bb404912580a13f82056", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"9a9b0145737842dcc78279103c5b3ff0b0b12e5c", "suffix":"pars-saturationstep", "text_descr":"SaturationStep runtime parameters", "tpn":"wfi_pars-saturationstep.tpn", @@ -707,7 +767,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"b490dcd7b81ce0c3933d0c63bd82f9c16fea942c", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"8b41475be16a1db03d703419103168f86c699b35", "suffix":"pars-skymatchstep", "text_descr":"SkyMatchStep runtime parameters", "tpn":"wfi_pars-skymatchstep.tpn", @@ -733,7 +797,12 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"d9ffff31a570b9007751d9f02ce55d837c7f4759", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE", + "META.INSTRUMENT.DETECTOR":"ROMAN.META.INSTRUMENT.DETECTOR" + }, + "sha1sum":"b75d3cf65fd36d719062bafc72053afe1aa1472e", "suffix":"pars-sourcedetectionstep", "text_descr":"SourceDetectionStep runtime parameters", "tpn":"wfi_pars-sourcedetectionstep.tpn", @@ -758,7 +827,11 @@ "ROMAN.META.EXPOSURE.START_TIME" ] ], - "sha1sum":"422cecde85ba2d852f63c96108e990418ca51df8", + "reference_to_dataset":{ + "META.EXPOSURE.START_TIME":"ROMAN.META.EXPOSURE.START_TIME", + "META.EXPOSURE.TYPE":"ROMAN.META.EXPOSURE.TYPE" + }, + "sha1sum":"73d54f6101ec8a8032651d564602f2214c7470f5", "suffix":"pars-tweakregstep", "text_descr":"TweakRegStep runtime parameters", "tpn":"wfi_pars-tweakregstep.tpn", diff --git a/crds/roman/specs/wfi_pars-assignwcsstep.rmap b/crds/roman/specs/wfi_pars-assignwcsstep.rmap index de8ff98a0..72e6d4113 100644 --- a/crds/roman/specs/wfi_pars-assignwcsstep.rmap +++ b/crds/roman/specs/wfi_pars-assignwcsstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-assignwcsstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '006b320c237efedf59afc98275582f6bf0ed619b', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '248deffa52bc0de6d8a44139fbd561467eb8cfb6', 'suffix' : 'pars-assignwcsstep', 'text_descr' : 'AssignWcsStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-darkcurrentstep.rmap b/crds/roman/specs/wfi_pars-darkcurrentstep.rmap index c37fde272..1faa8fb0d 100644 --- a/crds/roman/specs/wfi_pars-darkcurrentstep.rmap +++ b/crds/roman/specs/wfi_pars-darkcurrentstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-darkcurrentstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '45f4c04f38701c5ce6da2ed234a61c9f1ae36d00', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '3cde31e615ef4b38911578908c4dfd6649601f03', 'suffix' : 'pars-darkcurrentstep', 'text_descr' : 'DarkCurrentStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-dqinitstep.rmap b/crds/roman/specs/wfi_pars-dqinitstep.rmap index b6dcabf89..f739f4d9c 100644 --- a/crds/roman/specs/wfi_pars-dqinitstep.rmap +++ b/crds/roman/specs/wfi_pars-dqinitstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-dqinitstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : 'dd6cf0cdeacf634a860c39cdf438a06bc27097f3', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '0d25601ddf2b43f51ed54e1660db6e2c0f6c8dd4', 'suffix' : 'pars-dqinitstep', 'text_descr' : 'DQInitStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-exposurepipeline.rmap b/crds/roman/specs/wfi_pars-exposurepipeline.rmap index 35b643f23..1fd9efc79 100644 --- a/crds/roman/specs/wfi_pars-exposurepipeline.rmap +++ b/crds/roman/specs/wfi_pars-exposurepipeline.rmap @@ -9,7 +9,11 @@ header = { 'name' : 'roman_wfi_pars-exposurepipeline.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '07a8c2f7fe898212e56cc4854d4ff8c350b1c049', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '8a30602dce0211e962dac8988a35b3621287b564', 'suffix' : 'pars-exposurepipeline', 'text_descr' : 'Step parameters for ExposurePipeline', } diff --git a/crds/roman/specs/wfi_pars-flatfieldstep.rmap b/crds/roman/specs/wfi_pars-flatfieldstep.rmap index 6d4324db1..51f935429 100644 --- a/crds/roman/specs/wfi_pars-flatfieldstep.rmap +++ b/crds/roman/specs/wfi_pars-flatfieldstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-flatfieldstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '690afb5354f33be070cb5805053de4879a483fc1', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : 'fcdce6a7535888352a820f06a509bc2a28f2545c', 'suffix' : 'pars-flatfieldstep', 'text_descr' : 'FlatFieldStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-fluxstep.rmap b/crds/roman/specs/wfi_pars-fluxstep.rmap index b065ac9f3..dc0eae015 100644 --- a/crds/roman/specs/wfi_pars-fluxstep.rmap +++ b/crds/roman/specs/wfi_pars-fluxstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-fluxstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '6f243a719f87ea2f36a7cf7b6a128ec096eae71d', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '437697f4b39b3b3b02428c237da2d63e235662fb', 'suffix' : 'pars-fluxstep', 'text_descr' : 'FluxStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-highlevelpipeline.rmap b/crds/roman/specs/wfi_pars-highlevelpipeline.rmap index 3222aba80..cad2d0296 100644 --- a/crds/roman/specs/wfi_pars-highlevelpipeline.rmap +++ b/crds/roman/specs/wfi_pars-highlevelpipeline.rmap @@ -9,7 +9,11 @@ header = { 'name' : 'roman_wfi_pars-highlevelpipeline.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : 'a7c65100f35a11b668721a3c6853d7ad2ed6d597', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '3658f4741e2ca45ae61dc938f096d015477f821b', 'suffix' : 'pars-highlevelpipeline', 'text_descr' : 'Step parameters for HighLevelPipeline', } diff --git a/crds/roman/specs/wfi_pars-jumpstep.rmap b/crds/roman/specs/wfi_pars-jumpstep.rmap index 3afd431ab..3664aac87 100644 --- a/crds/roman/specs/wfi_pars-jumpstep.rmap +++ b/crds/roman/specs/wfi_pars-jumpstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-jumpstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '2476df99dd9bd0854a2545cf70d69f0c8707ba81', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '379be600ed1097bd929fe298b46b5ed25106852a', 'suffix' : 'pars-jumpstep', 'text_descr' : 'JumpStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-linearitystep.rmap b/crds/roman/specs/wfi_pars-linearitystep.rmap index cf1c6e114..348a9b3b3 100644 --- a/crds/roman/specs/wfi_pars-linearitystep.rmap +++ b/crds/roman/specs/wfi_pars-linearitystep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-linearitystep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : 'c88ea40348060277a00a098c169706a43ccff15f', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '9a70026939ad0626c4326a28b3f897d7559131af', 'suffix' : 'pars-linearitystep', 'text_descr' : 'LinearityStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-outlierdetectionstep.rmap b/crds/roman/specs/wfi_pars-outlierdetectionstep.rmap index a805d211c..80f3cda19 100644 --- a/crds/roman/specs/wfi_pars-outlierdetectionstep.rmap +++ b/crds/roman/specs/wfi_pars-outlierdetectionstep.rmap @@ -8,7 +8,12 @@ header = { 'name' : 'roman_wfi_pars-outlierdetectionstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE', 'ROMAN.META.INSTRUMENT.DETECTOR'), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : 'af4b3c2a128f8c2017286e8722e6917cfdacc0bb', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + 'META.INSTRUMENT.DETECTOR' : 'ROMAN.META.INSTRUMENT.DETECTOR', + }, + 'sha1sum' : 'b80e2be97322108a798b291a24a5de5a78804b3e', 'suffix' : 'pars-outlierdetectionstep', 'text_descr' : 'OutlierDetectionStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-photomstep.rmap b/crds/roman/specs/wfi_pars-photomstep.rmap index a2ec161bb..a9d7ddba1 100644 --- a/crds/roman/specs/wfi_pars-photomstep.rmap +++ b/crds/roman/specs/wfi_pars-photomstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-photomstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '15643a08ae7456d3cdee7cf0dd7c00b9a00cb601', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '1de85960b6993e63d6b11d70b36d74a985588ca6', 'suffix' : 'pars-photomstep', 'text_descr' : 'PhotomStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-rampfitstep.rmap b/crds/roman/specs/wfi_pars-rampfitstep.rmap index 0f76a95dc..10746e47f 100644 --- a/crds/roman/specs/wfi_pars-rampfitstep.rmap +++ b/crds/roman/specs/wfi_pars-rampfitstep.rmap @@ -9,7 +9,10 @@ header = { 'name' : 'roman_wfi_pars-rampfitstep.rmap', 'observatory' : 'ROMAN', 'parkey' : ((), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '1bbb7976ffd4c8695c8fd27d57cd6375eab73347', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + }, + 'sha1sum' : '517e9e9a09d86f38710398684afd0105924e15d0', 'suffix' : 'pars-rampfitstep', 'text_descr' : 'RampFitStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-refpixstep.rmap b/crds/roman/specs/wfi_pars-refpixstep.rmap index e2ea4f5ce..e4d9dc735 100644 --- a/crds/roman/specs/wfi_pars-refpixstep.rmap +++ b/crds/roman/specs/wfi_pars-refpixstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-refpixstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : 'b9fe9fba7c184531656180ac2ba8ed318c34e98d', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '0b4506700cb11e419cf2f56e0146aec9ca6e6ece', 'suffix' : 'pars-refpixstep', 'text_descr' : 'RefPixStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-resamplestep.rmap b/crds/roman/specs/wfi_pars-resamplestep.rmap index d3cbf8135..d9460fed2 100644 --- a/crds/roman/specs/wfi_pars-resamplestep.rmap +++ b/crds/roman/specs/wfi_pars-resamplestep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-resamplestep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '873e56616b3291f9efc613f467bc92902820e236', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '40a68a66c53deb1aa73cd5843db80b41dc07c94e', 'suffix' : 'pars-resamplestep', 'text_descr' : 'ResampleStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-saturationstep.rmap b/crds/roman/specs/wfi_pars-saturationstep.rmap index 648fa1a2f..7b70b48c2 100644 --- a/crds/roman/specs/wfi_pars-saturationstep.rmap +++ b/crds/roman/specs/wfi_pars-saturationstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-saturationstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '39a0355ed18fa062b217bb404912580a13f82056', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '9a9b0145737842dcc78279103c5b3ff0b0b12e5c', 'suffix' : 'pars-saturationstep', 'text_descr' : 'SaturationStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-skymatchstep.rmap b/crds/roman/specs/wfi_pars-skymatchstep.rmap index 3abc73c3b..d29aefca2 100644 --- a/crds/roman/specs/wfi_pars-skymatchstep.rmap +++ b/crds/roman/specs/wfi_pars-skymatchstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-skymatchstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : 'b490dcd7b81ce0c3933d0c63bd82f9c16fea942c', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '8b41475be16a1db03d703419103168f86c699b35', 'suffix' : 'pars-skymatchstep', 'text_descr' : 'SkyMatchStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-sourcedetectionstep.rmap b/crds/roman/specs/wfi_pars-sourcedetectionstep.rmap index c2004cc06..18092f9aa 100644 --- a/crds/roman/specs/wfi_pars-sourcedetectionstep.rmap +++ b/crds/roman/specs/wfi_pars-sourcedetectionstep.rmap @@ -8,7 +8,12 @@ header = { 'name' : 'roman_wfi_pars-sourcedetectionstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE', 'ROMAN.META.INSTRUMENT.DETECTOR'), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : 'd9ffff31a570b9007751d9f02ce55d837c7f4759', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + 'META.INSTRUMENT.DETECTOR' : 'ROMAN.META.INSTRUMENT.DETECTOR', + }, + 'sha1sum' : 'b75d3cf65fd36d719062bafc72053afe1aa1472e', 'suffix' : 'pars-sourcedetectionstep', 'text_descr' : 'SourceDetectionStep runtime parameters', } diff --git a/crds/roman/specs/wfi_pars-tweakregstep.rmap b/crds/roman/specs/wfi_pars-tweakregstep.rmap index ff81727f5..eff34d8b6 100644 --- a/crds/roman/specs/wfi_pars-tweakregstep.rmap +++ b/crds/roman/specs/wfi_pars-tweakregstep.rmap @@ -8,7 +8,11 @@ header = { 'name' : 'roman_wfi_pars-tweakregstep.rmap', 'observatory' : 'ROMAN', 'parkey' : (('ROMAN.META.EXPOSURE.TYPE',), ('ROMAN.META.EXPOSURE.START_TIME',)), - 'sha1sum' : '422cecde85ba2d852f63c96108e990418ca51df8', + 'reference_to_dataset' : { + 'META.EXPOSURE.START_TIME' : 'ROMAN.META.EXPOSURE.START_TIME', + 'META.EXPOSURE.TYPE' : 'ROMAN.META.EXPOSURE.TYPE', + }, + 'sha1sum' : '73d54f6101ec8a8032651d564602f2214c7470f5', 'suffix' : 'pars-tweakregstep', 'text_descr' : 'TweakRegStep runtime parameters', } diff --git a/test/certify/test_certify.py b/test/certify/test_certify.py index e34fca3e8..872decc23 100644 --- a/test/certify/test_certify.py +++ b/test/certify/test_certify.py @@ -3010,3 +3010,14 @@ def test_certify_pars_badschema(roman_test_cache_state, roman_data, caplog): expected = """Invalid instrument 'bad'""".splitlines() for line in expected: assert line in out + +# Uncomment once crds-cache-test repo has been updated +# @mark.roman +# @mark.certify +# def test_certify_roman_pars_jumpstep(roman_test_cache_state, roman_data): +# """Test certify for jumpstep parameter reference file. +# TODO: once it becomes possible to do so, this file should be created on the fly using +# roman_datamodels.maker_utils in order to test validation against the most current schema. +# The function for doing so should be added to test/data/roman/mkdata.py +# """ +# certify.certify_file(f"{roman_data}/roman_wfi_pars-jumpstep_0001.asdf", "roman_0006.pmap", observatory="roman") diff --git a/test/data/roman/roman_wfi_pars-jumpstep_0001.asdf b/test/data/roman/roman_wfi_pars-jumpstep_0001.asdf new file mode 100644 index 000000000..2019ad0d6 --- /dev/null +++ b/test/data/roman/roman_wfi_pars-jumpstep_0001.asdf @@ -0,0 +1,56 @@ +#ASDF 1.0.0 +#ASDF_STANDARD 1.5.0 +%YAML 1.1 +%TAG ! tag:stsci.edu:asdf/ +--- !core/asdf-1.1.0 +asdf_library: !core/software-1.0.0 {author: The ASDF Developers, homepage: 'http://github.com/asdf-format/asdf', + name: asdf, version: 3.2.0} +history: + extensions: + - !core/extension_metadata-1.0.0 + extension_class: asdf.extension._manifest.ManifestExtension + extension_uri: asdf://asdf-format.org/core/extensions/core-1.5.0 + software: !core/software-1.0.0 {name: asdf, version: 3.2.0} +class: romancal.jump.jump_step.JumpStep +meta: + author: William Schultz + date: '2024-06-05T00:00:00.710077' + description: Parameter File for WFI Romancal Jump Step + exposure: {p_exptype: WFI_IMAGE|WFI_GRISM|WFI_PRISM|, type: WFI_IMAGE} + instrument: {detector: WFI01, name: WFI, optical_element: F062, p_detector: WFI01|WFI02|WFI03|WFI04|WFI05|WFI06|WFI07|WFI08|WFI09|WFI10|WFI11|WFI12|WFI13|WFI14|WFI14|WFI16|WFI17|WFI18|, + p_optical_element: F062|F087|F106|F129|F146|F158|F184|F213|GRISM|PRISM|DARK|} + origin: STSCI + pedigree: DUMMY + reftype: pars-jumpstep + telescope: ROMAN + title: Jump Parameters + useafter: '2020-01-01T00:00:00' +name: JumpStep +parameters: + expand_factor: 2.0 + expand_large_events: false + flag_4_neighbors: true + four_group_rejection_threshold: 190.0 + input_dir: '' + max_jump_to_flag_neighbors: 1000.0 + maximum_cores: none + min_jump_area: 5.0 + min_jump_to_flag_neighbors: 10.0 + min_sat_area: 1.0 + output_dir: null + output_ext: .asdf + output_file: null + output_use_index: true + output_use_model: false + post_hooks: [] + pre_hooks: [] + rejection_threshold: 500.0 + sat_required_snowball: true + save_results: false + search_output_file: true + skip: false + suffix: null + three_group_rejection_threshold: 200.0 + use_ellipses: false + use_ramp_jump_detection: true +...