New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faraday dependency minimum should be 1.0 #187

Open

matt-eaton opened this issue Feb 21, 2025 · 0 comments

matt-eaton commented Feb 21, 2025

Not sure what is involved in setting a minimum dependency for Faraday. I think this line here:

spark_api/lib/spark_api/faraday_middleware.rb

Line 33 in 0c8b5df

CGI.parse(env[:request_body])

Will require Faraday 1.0.

This looks like the PR into the 1.0 release that adds the functionality to support "request_body".

spark_api/lib/spark_api/faraday_middleware.rb

Line 33 in 0c8b5df

CGI.parse(env[:request_body])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment