Add Kubedoom community pack #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karl-cardenas-coding
previously approved these changes
May 31, 2024
…loud/pack-central into kubedoom-community-pack
vishwanaths
requested changes
Jun 14, 2024
| - image: {{ .Values.images.kubedoom }} | ||
| env: | ||
| - name: NAMESPACE | ||
| value: default |
There was a problem hiding this comment.
should this also refer to {{ .Values.namespace }} ?
There was a problem hiding this comment.
The original manifest was like like this and it did not affect dyployment. but yeah i think it is supposed to be kubedoom
…loud/pack-central into kubedoom-community-pack
|
Closing this after discussion, as this is GNUPL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a community pack that lets users to play the video game Doom (1993) in a Kubernetes cluster on Edge. This is a fun pack that extends the internet phenomenon of running DOOM on anything.