Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Implement validation on the WithdrawalRequestReport #1323

Open
1 task
djordon opened this issue Feb 7, 2025 · 0 comments
Open
1 task

[Feature]: Implement validation on the WithdrawalRequestReport #1323

djordon opened this issue Feb 7, 2025 · 0 comments
Labels
sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation.

Comments

@djordon
Copy link
Collaborator

djordon commented Feb 7, 2025

Feature - Implement validation on the WithdrawalRequestReport

1. Description

The consensus rules for withdrawal requests are detailed in #741. When given a pre-sign request from the coordinator, each signer needs to validate the requests against the consensus rules. After #1308 gets done we will have an object that we can use to validate a withdrawal request using consensus rules. This task is to implement consensus rules for withdrawals in the validate function in the WithdrawalRequestReport, just like we do for the DepositRequestReport.

1.1 Context & Purpose

After the coordinator selects requests for inclusion in a sweep, it broadcasts a BitcoinPreSignRequest object to all peers containing all of the selected requests. The signers then validate all of these requests using consensus rules. For deposits this is done through DepositRequestReport::validate, while for withdrawals we will use WithdrawalRequestReport::validate. This ticket is about properly implementing WithdrawalRequestReport::validate.

2. Technical Details:

The consensus rules for withdrawals are in #741 and should be straightforward once the report has been constructed.

2.1 Acceptance Criteria:

  • The signers have the logic for applying consensus rules to an individual withdrawal request given a WithdrawalRequestReport.

3. Related Issues and Pull Requests (optional):

@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation. labels Feb 7, 2025
@djordon djordon added this to sBTC Feb 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Feb 7, 2025
@djordon djordon moved this from Needs Triage to Todo in sBTC Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation.
Projects
Status: Todo
Development

No branches or pull requests

1 participant