You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Feature - Implement validation on the WithdrawalRequestReport
1. Description
The consensus rules for withdrawal requests are detailed in #741. When given a pre-sign request from the coordinator, each signer needs to validate the requests against the consensus rules. After #1308 gets done we will have an object that we can use to validate a withdrawal request using consensus rules. This task is to implement consensus rules for withdrawals in the validate function in the WithdrawalRequestReport, just like we do for the DepositRequestReport.
1.1 Context & Purpose
After the coordinator selects requests for inclusion in a sweep, it broadcasts a BitcoinPreSignRequest object to all peers containing all of the selected requests. The signers then validate all of these requests using consensus rules. For deposits this is done through DepositRequestReport::validate, while for withdrawals we will use WithdrawalRequestReport::validate. This ticket is about properly implementing WithdrawalRequestReport::validate.
2. Technical Details:
The consensus rules for withdrawals are in #741 and should be straightforward once the report has been constructed.
2.1 Acceptance Criteria:
The signers have the logic for applying consensus rules to an individual withdrawal request given a WithdrawalRequestReport.
Feature - Implement validation on the
WithdrawalRequestReport
1. Description
The consensus rules for withdrawal requests are detailed in #741. When given a pre-sign request from the coordinator, each signer needs to validate the requests against the consensus rules. After #1308 gets done we will have an object that we can use to validate a withdrawal request using consensus rules. This task is to implement consensus rules for withdrawals in the validate function in the
WithdrawalRequestReport
, just like we do for theDepositRequestReport
.1.1 Context & Purpose
After the coordinator selects requests for inclusion in a sweep, it broadcasts a
BitcoinPreSignRequest
object to all peers containing all of the selected requests. The signers then validate all of these requests using consensus rules. For deposits this is done throughDepositRequestReport::validate
, while for withdrawals we will useWithdrawalRequestReport::validate
. This ticket is about properly implementingWithdrawalRequestReport::validate
.2. Technical Details:
The consensus rules for withdrawals are in #741 and should be straightforward once the report has been constructed.
2.1 Acceptance Criteria:
WithdrawalRequestReport
.3. Related Issues and Pull Requests (optional):
WithdrawalRequestReport
#1308The text was updated successfully, but these errors were encountered: