From aa695edee8ab32fb86dfe27cc70166fdf8d99af5 Mon Sep 17 00:00:00 2001
From: Etan Kissling <etan@status.im>
Date: Wed, 28 Feb 2024 21:27:24 +0100
Subject: [PATCH] avoid `XDeclaredButNotUsed` when no field `isnot JsonVoid`

Move the type definitions for `Writer` and `Flavor` closer to their
usage to avoid verbose hints when they are never used in an invocation.
---
 json_serialization/writer.nim | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/json_serialization/writer.nim b/json_serialization/writer.nim
index e28e75d..4700594 100644
--- a/json_serialization/writer.nim
+++ b/json_serialization/writer.nim
@@ -198,14 +198,13 @@ proc writeRecordValue*(w: var JsonWriter, value: auto)
   mixin enumInstanceSerializedFields, writeObjectField
   mixin flavorOmitsOptionalFields, shouldWriteObjectField
 
-  type
-    Writer = typeof w
-    Flavor = Writer.Flavor
-
   type RecordType = type value
   w.beginRecord RecordType
   value.enumInstanceSerializedFields(fieldName, fieldValue):
     when fieldValue isnot JsonVoid:
+      type
+        Writer = typeof w
+        Flavor = Writer.Flavor
       when flavorOmitsOptionalFields(Flavor):
         if shouldWriteObjectField(fieldValue):
           writeObjectField(w, value, fieldName, fieldValue)