From 33bcc8bee4d63dfa9cb6a2cdc509c20be6191025 Mon Sep 17 00:00:00 2001 From: Mona Steininger Date: Sat, 22 Jun 2024 17:13:11 +0200 Subject: [PATCH 1/4] try to fix contrast issue --- hanoi-frontend/src/jsMain/kotlin/lib/compose/modal/modal.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hanoi-frontend/src/jsMain/kotlin/lib/compose/modal/modal.kt b/hanoi-frontend/src/jsMain/kotlin/lib/compose/modal/modal.kt index baf2635..7a47076 100644 --- a/hanoi-frontend/src/jsMain/kotlin/lib/compose/modal/modal.kt +++ b/hanoi-frontend/src/jsMain/kotlin/lib/compose/modal/modal.kt @@ -32,7 +32,7 @@ fun ModalLayer( flexDirection(FlexDirection.Column) height(100.vh) backgroundColor(Color.black) - opacity(0.5) + opacity(1) if(bottomUp) { justifyContent(JustifyContent.FlexEnd) } @@ -148,4 +148,4 @@ fun Modal( } } } -} \ No newline at end of file +} From 114c95189791986b428dc3bbe57297d6c3ca2df9 Mon Sep 17 00:00:00 2001 From: Mona Steininger Date: Sat, 22 Jun 2024 17:30:45 +0200 Subject: [PATCH 2/4] try to fix contrast issue --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 03fa504..012200e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -52,6 +52,7 @@ jobs: - name: Install needed Chrome Version run: npm install -g chromedriver@125 - name: Run Axe with set Chromedriver path + continue-on-error: true run: axe http://localhost:8080, http://localhost:8080/game, http://localhost:8080/cheat, http://localhost:8080/solver --chromedriver-path $(npm root -g)/chromedriver/bin/chromedriver --exit - name: Comment on PR if: ${{ github.event_name == 'pull_request' }} From ee5155746d31edc31655b3985d214693f5fd44a8 Mon Sep 17 00:00:00 2001 From: Mona Steininger Date: Sat, 22 Jun 2024 17:52:28 +0200 Subject: [PATCH 3/4] try to comment issues on pr --- .github/workflows/main.yml | 14 +++++--------- .gitignore | 1 + 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 012200e..0318063 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -53,14 +53,10 @@ jobs: run: npm install -g chromedriver@125 - name: Run Axe with set Chromedriver path continue-on-error: true - run: axe http://localhost:8080, http://localhost:8080/game, http://localhost:8080/cheat, http://localhost:8080/solver --chromedriver-path $(npm root -g)/chromedriver/bin/chromedriver --exit + run: axe http://localhost:8080, http://localhost:8080/game, http://localhost:8080/cheat, http://localhost:8080/solver --chromedriver-path $(npm root -g)/chromedriver/bin/chromedriver --exit >> results - name: Comment on PR if: ${{ github.event_name == 'pull_request' }} - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - pr_number=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH") - curl -s -H "Authorization: token $GITHUB_TOKEN" \ - -X POST \ - -d "{\"body\": \"Thank you for your contribution! We are reviewing your pull request.\"}" \ - "https://api.github.com/repos/${{ github.repository }}/issues/$pr_number/comments" + uses: JoseThen/comment-pr@v1.2.0 + with: + file_path: './results' + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.gitignore b/.gitignore index 04a7ad2..ff91780 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,4 @@ *.iml build kotlin-js-store +results From aea4562b7020e67f4d0b8e91f6fe78eb6db7ec5b Mon Sep 17 00:00:00 2001 From: Mona Steininger Date: Sat, 22 Jun 2024 18:04:34 +0200 Subject: [PATCH 4/4] fail the run if result files exist --- .github/workflows/main.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0318063..8f143ff 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,9 +1,6 @@ name: CI Pipeline Hanoi Towers on: - push: - branches: - - master pull_request: types: [opened, synchronize, reopened] @@ -18,7 +15,7 @@ jobs: HANOI_FRONTEND_URL: ${{ vars.HANOI_FRONTEND_URL }} HANOI_BACKEND_URL: ${{ vars.HANOI_BACKEND_URL }} steps: - - name: Checkout + - name: Checkout Repository uses: actions/checkout@v4.1.7 - name: Set up .env files run: | @@ -60,3 +57,11 @@ jobs: with: file_path: './results' GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Fail if results file exists + run: | + if [ -f "./results" ]; then + echo "Results file with accessibility issues exists - Details in PR-comment. Failing the workflow." + exit 1 + else + echo "No errors, be sure to still check manually for accessibility ;)" + fi