Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: remove captive-core-use-db parameter #5537

Closed
mollykarcher opened this issue Nov 20, 2024 · 1 comment
Closed

services/horizon: remove captive-core-use-db parameter #5537

mollykarcher opened this issue Nov 20, 2024 · 1 comment

Comments

@mollykarcher
Copy link
Contributor

What problem does your feature solve?

Core team wants to remove support for in-memory mode. Core's -in-memory mode proxy's directing to our captive-core-use-db config param, which is currently deprecated, but still exists.

What would you like to see?

  • Remove the captive-core-use-db flag. Behavior should now be forced into "true" for this flag.
  • Remove anywhere else that we may pass the --in-memory flag to captive core
  • Remove the flag from any internal/external documentation
  • Update puppet deployments to remove the flag
  • Update k8s manifests/helm charts to remove the flag

Note that this is technically a breaking change so it should align with a protocol boundary. Core wants to make their corresponding breaking change in a minor version release. Ideally, this should wait for protocol 23, but pending outcome of slack discussion here if Core will defer their change.

Related:

@mollykarcher mollykarcher moved this from Backlog to To Do in Platform Scrum Jan 14, 2025
@tamirms tamirms added this to the platform sprint 56 milestone Feb 11, 2025
@urvisavla urvisavla self-assigned this Feb 18, 2025
@urvisavla urvisavla moved this from To Do to In Progress in Platform Scrum Feb 18, 2025
@tamirms tamirms self-assigned this Feb 25, 2025
@tamirms
Copy link
Contributor

tamirms commented Mar 5, 2025

#5617 is relevant to this issue.

We should remove the code which includes DEPRECATED_SQL_LEDGER_STATE in the core toml from the ingestion library

@tamirms tamirms removed their assignment Mar 11, 2025
@urvisavla urvisavla moved this from In Progress to Needs Review in Platform Scrum Mar 21, 2025
@tamirms tamirms closed this as completed Mar 21, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants