Problem with e2e tests

[pahan35]

I noticed that you have broken e2e tests.

Actually, there are 2 broken tests.

1. should have a dark background in addon-backgrounds in file addon-backgrounds.spec.ts
   
2. should provide source snippet in addon-docs in file addon-docs.spec.ts.
   

The 2nd one looks like an easy fix: just need to adjust the match pattern, if the expected output is changed. Can somebody clarify what should we do here?

The 1st one is a bit unclear. It should have the expected value, but for some reason test fails. Does anybody have any idea how to get access to the recorded video and the screenshot? They are mentioned in the report log.

[shilman]

Thanks for raising this @pahan35. I believe @gaetanmaisse has been looking into this.

1. I have no idea what's going on in the first issue -- needs debugging. Maybe something to do with the major rearchitecture of core in 6.4?
2. The second issue is a bug and I'm probably best suited to track it down. There are two types of source snippets in addon-docs: static snippets that come from the original source code of the story, and dynamically-generated snippets that are generated from the output result of the story function. The test says that it should NOT be the former, but somehow it is in this case.

As for the artifacts, you should be able to access them in the Circle CI run:

[pahan35]

I've reproduced 1st bug in my environment. I'll find a way how to fix it.

P.S: with artifacts, it's much easier. Thanks for your guidance!

[pahan35]

It looks like the theme is not updated when PreviewContainer is rendered.

storybook/lib/components/src/blocks/Preview.tsx

Line 100 in ded097e

...getBlockBackgroundStyle(theme),

storybook/lib/components/src/blocks/BlockBackgroundStyles.tsx

Lines 3 to 9 in ded097e

	export const getBlockBackgroundStyle: (theme: Theme) => object = (theme: Theme) => ({
	borderRadius: theme.appBorderRadius,
	background: theme.background.content,
	boxShadow:
	theme.base === 'light' ? 'rgba(0, 0, 0, 0.10) 0 1px 3px 0' : 'rgba(0, 0, 0, 0.20) 0 2px 5px 0',
	border: `1px solid ${theme.appBorderColor}`,
	});

[pahan35]

@gaetanmaisse please let me know if I can help with any of those bugs.