Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmos-operator should be able to use private images #415

Closed
danbryan opened this issue Apr 24, 2024 · 1 comment
Closed

cosmos-operator should be able to use private images #415

danbryan opened this issue Apr 24, 2024 · 1 comment

Comments

@danbryan
Copy link
Contributor

danbryan commented Apr 24, 2024

cosmos-operator should allow the specification of imagePullSecrets when pulling an image.

@pharr117
Copy link
Contributor

pharr117 commented May 19, 2024

I am doing a dive into this, and I found this in the config sample:

imagePullSecrets:
- name: name-of-kube-secret
nodeSelector:

func podPatch(crd *cosmosv1.CosmosFullNode) *corev1.Pod {
tpl := crd.Spec.PodTemplate
// For fields with sliceOrDefault if you pass nil, the field is deleted.
spec := corev1.PodSpec{
Affinity: tpl.Affinity,
Containers: sliceOrDefault(tpl.Containers, []corev1.Container{}),
ImagePullSecrets: sliceOrDefault(tpl.ImagePullSecrets, []corev1.LocalObjectReference{}),
InitContainers: sliceOrDefault(tpl.InitContainers, []corev1.Container{}),
NodeSelector: tpl.NodeSelector,
Priority: tpl.Priority,
PriorityClassName: tpl.PriorityClassName,
TerminationGracePeriodSeconds: valOrDefault(tpl.TerminationGracePeriodSeconds, ptr(int64(30))),
Tolerations: sliceOrDefault(tpl.Tolerations, []corev1.Toleration{}),
Volumes: sliceOrDefault(tpl.Volumes, []corev1.Volume{}),
}
return &corev1.Pod{Spec: spec}
}

It may already be supported, I will try some tests on this to see if it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants